Fix icon clipping

[jamesreprise]

What is the goal of this PR?

We've fix a bug we introduced a bug in:

• https://github.com/vaticle/typedb-studio/pull/629

where the size of icons was initialised as "Unspecified". As a result, certain icons became 'clipped', see:

We believe the cause of this is that the function .sp doesn't have enough information in order to construct a TextUnit value at the time that the object is constructed. As such, it gives a TextUnit value of "Unspecified".

What are the changes implemented in this PR?

The only other place we use .sp in our application is in //framework/common/theme/Typography.kt, where we follow the pattern of declaring our sizes as const Ints and transforming them into TextUnit values later with .sp. We now follow this pattern in //framework/material/Icon.kt

We've also made all the Icon enum class constructor arguments named.

[typedb-bot]

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

---

Code

• [x] Packages, classes, and methods have a single domain of responsibility.
• [x] Packages, classes, and methods are grouped into cohesive and consistent domain model.
• [x] The code is canonical and the minimum required to achieve the goal.
• [x] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
• [x] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
• [x] The code is algorithmically efficient and scalable for the whole application.

Architecture

• [x] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
• [x] Any required build and release automations are updated and/or implemented.
• [x] Any new components follows a consistent style with respect to the pre-existing codebase.
• [x] The architecture intuitively reflects the application domain, and is easy to understand.
• [x] The architecture has a well-defined hierarchy of encapsulated components.
• [x] The architecture is extensible and scalable.