Open james-whiteside opened 1 year ago
Seeing as ownerships are represented as edges in the graph visualisation, it may involve a major refactor to make them clickable buttons to trigger explanations. If this is the case, then we can work around this temporarily by making clicking on the attribute itself the trigger to explain the ownership. While this would normally conflict with explaining an inferred attribute itself, this is not currently the case as the server does not allow directly explaining attributes unless they have no owners in the graph (whether this is a bug or feature is a controversial topic). This means that the server is only able to return one response in a given situation, so there should be no ambiguity in how to handle the request for explanation. The ideal would be of course to double click on the ownership itself to explain it. What is important is that: a) we can explain ownerships, b) the explanation is correct, and c) there is no danger of throwing an error halfway through a demo. If we have time, we'll record the demo in advance so can retake, but this may not be possible.
We have a fix for this, but I'm leaving it on a feature branch for now due to performance concerns.
Some of the red highlighting on explanation edges is inconsistent in the fix. Will likely need to revisist that aspect.
Description
Inferred ownership edges are not explainable or highlighted in green.
Environment
Reproducible Steps
Run queries in order:
Expected Output
Ownership edge between the owner of "entity-2" and the attribute "ownership" should be explainable.
Actual Output
It is not.