Closed 4c0n closed 11 months ago
Hi! I ran into a false positive when running mypy in combination with this package. Actually the format parameter can also be None in the get_url() method, it is passed to reverse() where the default value also is None. We've been using it like this in our application for a long time and it works fine like that. Please see: https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/relations.py#L326 https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/reverse.py#L32
format
None
get_url()
reverse()
Thanks in advance for your time and consideration.
I didn't create an issue, should I?
I have made things!
Hi! I ran into a false positive when running mypy in combination with this package. Actually the
formatparameter can also beNonein theget_url()method, it is passed toreverse()where the default value also isNone. We've been using it like this in our application for a long time and it works fine like that. Please see: https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/relations.py#L326 https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/reverse.py#L32Thanks in advance for your time and consideration.
Related issues
I didn't create an issue, should I?