search

typeddjango / djangorestframework-stubs

PEP-484 stubs for django-rest-framework
MIT License
439 stars 115 forks source link

CI: Run tests daily to detect incompatible django-stubs changes #519

Closed intgr closed 5 months ago

intgr commented 10 months ago

I have made things!

Motivated by examples like #518, #508 and many others. It happens every few weeks that a change in django-stubs also requires followup changes in djangorestframework-stubs.

Currently, I only find out when someone opens a PR against DRF-stubs and then CI fails. Having scheduled CI would help me be more proactive about these.

Alternatively, we could also change django-stubs CI to automatically trigger workflow_dispatch in DRF-stubs repo on every merge to master. But that would have more moving parts. I think daily schedule is good enough for the time being.

intgr commented 5 months ago

@sobolevn This would be useful. It bit us again, ref: #596

sobolevn commented 5 months ago

The next step is to open issues when it fails: see https://github.com/python/typeshed/blob/29db988c0a7c7784782fd28e2e250ba852e3fb72/.github/workflows/daily.yml#L131