search

typeddjango / pytest-mypy-plugins

pytest plugin for testing mypy types, stubs, and plugins
https://pypi.org/project/pytest-mypy-plugins/
MIT License
100 stars 26 forks source link

Support for older pytest #150

Closed delfick closed 4 months ago

delfick commented 4 months ago

Hi, I'm wondering how important it is to you for this plugin to continue supporting pytest 6?

Is pytest 7/8 are old enough to warrant removing the code that makes this plugin compatible with pytest 6 or would you rather keep that support?

sobolevn commented 4 months ago

pytest6 is not relevant anymore, we should not keep any support for it. Cleaner code, simplier workflow.

delfick commented 4 months ago

Awesome, I'll make a PR :)

On Fri, 3 May 2024, 18:50 Nikita Sobolev, @.***> wrote:

pytest6 is not relevant anymore, we should not keep any support for it. Cleaner code, simplier workflow.

— Reply to this email directly, view it on GitHub https://github.com/typeddjango/pytest-mypy-plugins/issues/150#issuecomment-2092580542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2V5OQ677PW2HBXXX2HJ3ZANFWFAVCNFSM6AAAAABHESWKBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGU4DANJUGI . You are receiving this because you authored the thread.Message ID: @.***>

delfick commented 4 months ago

@sobolevn also, speaking of compatibility. Python 3.8 is end of life in later in the year, do you want to keep support for it till then, or is it ok to remove support for it and be able to use PEP 585 in this repo?

(Though, in finding that link I noticed that we can already make use of that with a from __future__ import annotations it seems)

sobolevn commented 4 months ago

Yes, we need 3.8 for now. django-stubs should drop it first.

delfick commented 4 months ago

ok, fair enough. The good news is it appears django 5 only supports python 3.10 and above, so I imagine django-stubs could maybe drop it soon?

sobolevn commented 4 months ago

yes, we will drop it as soon as it will reach EOL