search

typeddjango / pytest-mypy-plugins

pytest plugin for testing mypy types, stubs, and plugins
https://pypi.org/project/pytest-mypy-plugins/
MIT License
99 stars 26 forks source link

Add missing regex dependency in setup.py #61

Closed MatthieuDartiailh closed 3 years ago

MatthieuDartiailh commented 3 years ago

Do not install dev requirements when testing, there are not useful and black dependency on regex was hiding the lack of regex in setup.py

Closes #60

sobolevn commented 3 years ago

Looks like we also need dataclasses for python < 3.7

MatthieuDartiailh commented 3 years ago

Indeed. Do you prefer a condition based on PEP 508 (https://hynek.me/articles/conditional-python-dependencies/) or a direct sys.version_info check ?

sobolevn commented 3 years ago

PEP 508 🙂

MatthieuDartiailh commented 3 years ago

Need your blessing to run tests @sobolevn

sobolevn commented 3 years ago

Thanks a lot!

MatthieuDartiailh commented 3 years ago

You are welcome !