Closed zero323 closed 1 year ago
I think that we should do it quite after the end-of-life. Because we are a testing tool. Other people might still support it in their projects.
Moreover, typing in 3.6 is completely different (not inference, but internals). Which might also be really important for our not-so-big userbase 🙂
Makes sense. Let's leave it open anyway ‒ its time will come one day!
BTW Do you think it is OK to add Python 3.10 to test matrix?
Yes, totally! But, I think there might be issues with black
.
Yes, totally! But, I think there might be issues with
black
.
At first glance
FROM python:3.10.0-buster
RUN useradd dev \
&& mkdir /home/dev \
&& chown dev:dev /home/dev
RUN apt update \
&& apt install -y git python3-pip \
&& rm -rf /var/cache/apt/*
USER dev
WORKDIR /home/dev
RUN python3 -m venv .venv
ENV PATH /home/dev/.venv/bin/:${PATH}
RUN git clone https://github.com/typeddjango/pytest-mypy-plugins.git
WORKDIR /home/dev/pytest-mypy-plugins
RUN pip3 install --upgrade pip \
&& pip3 install -r dev-requirements.txt \
&& pip3 install setuptools wheel
CMD pip install -e . \
&& pytest \
&& mypy . \
&& black --check pytest_mypy_plugins setup.py \
&& isort --check --diff .
things look OK (I've opened #71 to handle distutils
deprecation).
============================= test session starts ==============================
platform linux -- Python 3.10.0, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /home/dev/pytest-mypy-plugins, configfile: pytest.ini
plugins: mypy-plugins-1.9.0
collected 37 items
pytest_mypy_plugins/tests/test-extension.yml .
pytest_mypy_plugins/tests/test-parametrized.yml ......
pytest_mypy_plugins/tests/test-paths-from-env.yml ...
pytest_mypy_plugins/tests/test-regex_assertions.yml ......
pytest_mypy_plugins/tests/test-simple-cases.yml ..........
pytest_mypy_plugins/tests/test_utils.py ...........
=============================== warnings summary ===============================
pytest_mypy_plugins/tests/test-extension.yml::reveal_type_extension_is_loaded
/home/dev/pytest-mypy-plugins/pytest_mypy_plugins/item.py:199: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
import distutils.spawn
-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================== 37 passed, 1 warning in 52.37s ========================
Success: no issues found in 8 source files
All done! ✨ 🍰 ✨
8 files would be left unchanged.
Skipped 2 files
Awesome! 🎉
Python 3.6 is going to reach the end of its lifespan in 2021-12, so it is probably time to drop it from supported versions.