search

typefacedesign / document-driven-typedesign

Document Driven Typedesign
testmyfont.com
11 stars 3 forks source link

Append " GF" to families loaded from the Google Fonts API #67

Closed s3thi closed 9 years ago

s3thi commented 9 years ago

This bug manifests itself in a strange way.

  1. Drag Roboto from disk into DDT.
  2. Add Roboto from Google Fonts to the app.

This workflow works as expected, with the Google Fonts version of Roboto being named "Roboto 2" in DDT. But the following workflow does not work correctly:

  1. Drag Roboto from disk into DDT.
  2. Drag a different version of Roboto from disk into DDT. This results in a new family called "Roboto 2".
  3. Add Roboto from Google Fonts to the app. This does not work, and an exception is thrown with the message "A font family with this name already exists."

The correct behavior in this case is the Google Fonts version of Roboto being named "Roboto 3".

davelab6 commented 9 years ago

The correct behavior in this case is the Google Fonts version of Roboto being named "Roboto 3".

Actually, I would like all Google Fonts families to have GF appended to their family name, so it is clear they are loaded from the Google Fonts API. That should solve this bug and provide helpful addtional information to the user.

s3thi commented 9 years ago

Instead of appending "GF" to the family name, would it be a better idea to have an icon next to the family name that indicates the source?

davelab6 commented 9 years ago

Text does the job and keeps it simple On 10 Mar 2015 17:06, "Ankur Sethi" notifications@github.com wrote:

Instead of appending "GF" to the family name, would it be a better idea to have an icon next to the family name that indicates the source?

— Reply to this email directly or view it on GitHub https://github.com/metapolator/ddt/issues/67#issuecomment-78037386.