search

typegoose / mongodb-memory-server

Manage & spin up mongodb server binaries with zero(or slight) configuration for tests.
https://typegoose.github.io/mongodb-memory-server/
MIT License
2.58k stars 187 forks source link

fix: Fix binary download on debian testing/unstable #787

Closed orgads closed 1 year ago

orgads commented 1 year ago

VERSION_ID was removed. See https://tracker.debian.org/news/1433360/accepted-base-files-13-source-into-unstable/

and a similar bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1008735

hasezoey commented 1 year ago

what exactly has this PR to do with the mentioned email thread? and what exactly does this fix?

please add a test to illustrate what the change is meant to cover. tests can be found here

orgads commented 1 year ago

Updated the commit message, added tests and fixed some more cases.

codecov[bot] commented 1 year ago

Codecov Report

Merging #787 (0fe6809) into master (36bc050) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   90.38%   90.39%           
=======================================
  Files          14       14           
  Lines        1935     1937    +2     
  Branches      502      503    +1     
=======================================
+ Hits         1749     1751    +2     
  Misses        177      177           
  Partials        9        9
Files Changed Coverage Δ
...ory-server-core/src/util/MongoBinaryDownloadUrl.ts 93.63% <100.00%> (+0.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 8.15.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 9.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: