search

typegoose / mongodb-memory-server

Manage & spin up mongodb server binaries with zero(or slight) configuration for tests.
https://typegoose.github.io/mongodb-memory-server/
MIT License
2.56k stars 185 forks source link

Add support for amazon linux 2023 #826

Closed georgehb closed 10 months ago

georgehb commented 10 months ago

The os string in the download url for amazon linux 2023 should be "amazon2023"

Related Issues

georgehb commented 10 months ago

also how would versions like 6.0.6 be handled? because from what i can tell there are only releases for amazon2 for the 6.0.x series, are they compatible with the 2023 version?

According to their docs, mongodb doesn't support mongodb version less than 7 on amazon 2023 https://www.mongodb.com/docs/manual/administration/production-notes/#platform-support-matrix

I just tried it to see what would happen if you attempted to start mongod 6.0.6 on al2023 and at least on the base al2023 image, the mongo instance failed to start due to a missing library. So I'd say they aren't compatible

georgehb commented 10 months ago

I have added tests

codecov[bot] commented 10 months ago

Codecov Report

Merging #826 (3d91620) into master (7193799) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          15       15           
  Lines        1965     1965           
  Branches      494      494           
=======================================
  Hits         1791     1791           
  Misses        165      165           
  Partials        9        9
Files Coverage Δ
...ory-server-core/src/util/MongoBinaryDownloadUrl.ts 94.77% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 9.1.0-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 9.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: