search

typegoose / mongodb-memory-server

Manage & spin up mongodb server binaries with zero(or slight) configuration for tests.
https://typegoose.github.io/mongodb-memory-server/
MIT License
2.56k stars 185 forks source link

Update test-runners.md #829

Closed maxfriedmann closed 10 months ago

maxfriedmann commented 10 months ago

Add missing await

Related Issues

codecov[bot] commented 10 months ago

Codecov Report

Merging #829 (409188d) into master (7193799) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          15       15           
  Lines        1965     1965           
  Branches      494      494           
=======================================
  Hits         1791     1791           
  Misses        165      165           
  Partials        9        9

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

hasezoey commented 10 months ago

getUri is not async, did you mean something else? https://github.com/nodkz/mongodb-memory-server/blob/7193799203dc0a6a53902cbb6cfda81d2d526fa8/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts#L713

maxfriedmann commented 10 months ago

Oops, am still working with v6.9.2 (https://github.com/nodkz/mongodb-memory-server/blob/v6.9.2/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts#L240)

I am so sorry!