search

typekpb / oradown

Enables download of the SSO protected files from the Oracle website.
MIT License
10 stars 3 forks source link

Fix processing password with spec symbols. #7

Closed DenisShalaevSetronica closed 5 years ago

DenisShalaevSetronica commented 5 years ago

caused by https://github.com/typekpb/oradown/issues/6

DenisShalaevSetronica commented 5 years ago

You right. I tested it wrong. But i think is needed to add single quotes in to the usage documentation to avoid problems with complex passwords.

antoineco commented 5 years ago

Glad it worked, and sorry for the late response!

i think is needed to add single quotes in to the usage documentation to avoid problems with complex passwords

Not a bad suggestion, but this really is a global rule for all POSIX-compliant shell environments (sh, bash, zsh, ...). It is valid not only for the execution of Bash scripts, but for any program executed on such command line interface. E.g. if you grep a string that contains special characters you also have to escape these according to your shell.

We can't make assumptions about the shell the user is going to run the script from, but I believe it is safe to say the user is responsible for passing all arguments in a way that his/her execution environment understands.