typelead / eta-hackage

A set of patches to make Hackage compatible with the Eta language.
64 stars 31 forks source link

Patching Duckling #144

Closed jneira closed 5 years ago

jneira commented 5 years ago

Fixes #143

argideritzalpea commented 5 years ago

Hi @jneira - please forgive my ignorance, but is snap-core inherently incompatible with 'eta' or would it require its own patch? We are hoping to use duckling-example-exe in our application.

I got 'duckling-test' to build successfully

but does not pass the unit tests:

Duckling Tests
  API Tests
    Parse Test:                    FAIL
      Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined
    Rank Tests
      Rank Filter Tests:           FAIL
        Exception: JException java.lang.NullPointerException
      Rank Order Tests:            FAIL
        Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined
    Range Tests:                   FAIL
      Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined

...

jneira commented 5 years ago

No worries! snap could be patched for eta (like warp/wai) but maybe it could be quite work. However i will give a try to confirm it. I'll take a look to test suite errors, i hope it can be fixed without too much problems.