search

typelead / eta-hackage

A set of patches to make Hackage compatible with the Eta language.
64 stars 31 forks source link

Patched entropy-0.4 #71

Closed NickSeagull closed 6 years ago

rahulmutt commented 6 years ago

The patch still seems to be failing because of whitespace, as predicted. 

> git apply --ignore-whitespace --ignore-space-change ../../Downloads/entropy-0.4.patch 
../../Downloads/entropy-0.4.patch:632: trailing whitespace.
build-type:  Simple
../../Downloads/entropy-0.4.patch:648: trailing whitespace.
  other-modules: System.EntropyJVM
../../Downloads/entropy-0.4.patch:672: trailing whitespace.
  java-sources:        java/Utils.java
../../Downloads/entropy-0.4.patch:167: new blank line at EOF.
+
error: patch failed: entropy.cabal:42
error: entropy.cabal: patch does not apply
../../Downloads/entropy-0.4.patch:703: new blank line at EOF.
+

What I'll do is merge your patch and see if I can fix this.

rahulmutt commented 6 years ago

I fixed your patch here: https://github.com/typelead/eta-hackage/commit/dd53763d4fd0b0f800566e7bd7cf2bcab8dd0220

Turns out the problem was more than just whitespace :) It seems the cabal file you patched was different than the cabal file you get via etlas get.