typelead / eta-hackage

A set of patches to make Hackage compatible with the Eta language.
64 stars 31 forks source link

Patched directory-1.3.1.0: avoid the use of tryIOError in createDirectoryIfMissing #77

Closed jneira closed 6 years ago

jneira commented 6 years ago
rahulmutt commented 6 years ago

@jneira Thanks for the patch! Unfortunately, I am not able to see the contents to give a review - GitHub says that it's a binary file. What command did you use to generate the patch?

jneira commented 6 years ago

mmm, git format-patch HEAD~ --stdout > directory-1.3.1.0.patch as always i recently upgrade git for windows:

PS C:\Users\Javier\dev\lang\eta\eta-hackage> git --version
git version 2.16.2.windows.1
jneira commented 6 years ago

@rahulmutt i've repeated the steps and the file continue being binary :-/ The last try was: git format-patch HEAD~ --ignore-cr-at-eol --stdout > directory-1.3.1.0.patch With that the stats are:

 System/Directory.hs                  | 785 ++++++++++-------------------------
 System/Directory/Internal.hs         |  35 +-
 System/Directory/Internal/Config.hs  |   6 +-
 System/Directory/Internal/Prelude.hs |   6 +-
 directory.cabal                      |  17 +-
 java/Utils.java                      | 135 ++++++
 6 files changed, 381 insertions(+), 603 deletions(-)
 create mode 100644 java/Utils.java
rahulmutt commented 6 years ago

@jneira Ok I'll merge it in then since you've most likely done the correct fix. If there's any problem, I'll revert.