search

typelead / eta-hackage

A set of patches to make Hackage compatible with the Eta language.
64 stars 31 forks source link

directory-1.3.1.0 fix createDirectoryIfMissing #79

Closed rahulmutt closed 6 years ago

rahulmutt commented 6 years ago

@jniera, unfortunately I'm getting the following error from your patch file:

Found patch in eta-hackage for directory-1.3.1.0
etlas: '/usr/bin/git' exited with an error:
fatal: unrecognized input

I've temporarily reverted your changes so that builds don't break. If at all possible can you revert your git version and see if that helps?

jneira commented 6 years ago

Hi, sorry for the additional work. I am trying to make the patch in dos console (instead powershell, see https://stackoverflow.com/questions/13675782/git-shell-in-windows-patchs-default-character-encoding-is-ucs-2-little-endian) and i get to avoid the fatal: unrecognized input. However i am testing the patch locally and i get some rejected hunks and a bad version.

jneira commented 6 years ago

Ok, after reset the package to the initial state the patch created in dos console is correctly applied and the package builds so the problem was using git format-patch in powershell I'll go ahead and request a new pr with the well-formed patch

rahulmutt commented 6 years ago

@jneira Can this be closed now?

jneira commented 6 years ago

closing!