Fix Windows long path issues

typelead / etlas

Etlas, the build tool and package manager for the Eta programming language

63 stars 10 forks source link

Fix Windows long path issues #52

Closed Kawzeg closed 6 years ago

Kawzeg commented 6 years ago

Taken from https://github.com/haskell/cabal/pull/4977/files

Fixes typelead/eta#691

CLAassistant commented 6 years ago

All committers have signed the CLA.

rahulmutt commented 6 years ago

@jneira Can you take a look at this?

jneira commented 6 years ago

@rahulmutt sure! @Kawzeg thank very much, this will do the windows experience much better

jneira commented 6 years ago

Sorry for not update the pr but yesterday at late night i tested the pr in win 10 and i got errors even for short paths. I want to test it in another win version to be sure though. It works for cabal 2.2 so it should work for etlas but maybe other changes of cabal makes it work. @Kawzeg did it work for you in some windows env?

rahulmutt commented 6 years ago

Reverted in #53. @Kawzeg Can you take a look and see if you can fix the issue and submit a new PR?

Kawzeg commented 6 years ago

@jneira I built this on my Win 7 machine because the long path issue prevented me from building some dependency, and it worked for me, though I didn't test it extensively and may have mixed up some changes. I'll try if I can get it to work on win 10.

@rahulmutt I will try!

jneira commented 6 years ago

@Kawzeg It works for me in win 7 too:

Setting the store-dir with a path around 50 (it fails for 60). Commenting out the property works too cause the default store-dir in %APPDATA%\etlas\store is 37 for me.
The previous version fails with paths around 30
So hopefully the new version will work for most windows users without the workaround of setting the store-dir prop to a shorter path
I guess the project being built will need to have a path in those limits, taking in account the dirs created in dist

In win 10 i've tested it with store-dir: D:\sd in %APPDATA%\etlas\config file and it throwed errors related with handling the package-db dir, so maybe change that property is related with the error. I will try again later from scratch.

rahulmutt commented 6 years ago

@Kawzeg Your PR was good. @jneira verified that stale build artifacts and already existing bugs were the cause and not your changes. I've undone the revert in #54.

jneira commented 6 years ago

Yeah, @Kawzeg, sorry for the false positive and thanks again for the fix