search

typelead / gradle-eta

Gradle plugin for the Eta programming language
BSD 3-Clause "New" or "Revised" License
30 stars 7 forks source link

Append .exe to Windows binaries #4

Closed carymrobbins closed 6 years ago

carymrobbins commented 6 years ago

From Gitter

Psybur When running gradlew compileEta Im getting this: > Failed to fetch file from url: http://88a2a1b21f8e03a6bc8d-8f2e61d843ea88e4f30ab3f81ca0e396.r42.cf5.rackcdn.com/etlas-1.0.2.0/binaries/x86_64-windows/etlas

Rahul Muttineni That url should be http://88a2a1b21f8e03a6bc8d-8f2e61d843ea88e4f30ab3f81ca0e396.r42.cf5.rackcdn.com/etlas-1.0.2.0/binaries/x86_64-windows/etlas.exe

In the same way that we do a platform check in EtlasBinaryDependencyResolver#resolveRemote we need to append .exe to binary names in EtlasBinaryDependencyResolver#getEtlasUrlString.

jrciii commented 6 years ago

resolveInSystemPath() also needs to be modified. Perhaps others too, but can verify this one definitely needs it.

carymrobbins commented 6 years ago

@jrciii - I have a branch and PR out that should resolve this issue - 4-windows-binaries

If you can, try it out and let me know if this works for you. Otherwise we can review and merge.

carymrobbins commented 6 years ago

I'm going to go ahead and close this for now, @jrciii please reopen if you encounter any issues with this moving forward.