Let Ring and CommutativeRing companions extend RingFunctions.

typelevel / algebra

Experimental project to lay out basic algebra type classes

https://typelevel.org/algebra/

Other

378 stars 69 forks source link

Closed TomasMikula closed 8 years ago

TomasMikula commented 8 years ago

It seemed like an oversight that object Ring did not extend RingFunctions.

tixxit commented 8 years ago

This LGTM, but should we also use this in EuclideanRingFunctions and FieldFunctions too?

TomasMikula commented 8 years ago

Right, I will add those. I did this as a preparatory refactoring for #98, so I only did the minimum relevant for that and did not look around.

TomasMikula commented 8 years ago

Added.

non commented 8 years ago

Looks good. :+1:

non commented 8 years ago

Where does this PR stand? Did we decide to parameterize the RingFunctions trait?

johnynek commented 8 years ago

I thought we did decide to parameterize RingFunctions.

non commented 8 years ago

OK great, so we're waiting on that. Thanks!

TomasMikula commented 8 years ago

Check out the new commit.

TomasMikula commented 8 years ago

Oops, turns out I didn't merge the current master to my working copy.

TomasMikula commented 8 years ago

Fixed, let's see what Travis says now.

non commented 8 years ago

:+1: