search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

Remove code duplicated from cats-kernel. #182

Closed tixxit closed 7 years ago

tixxit commented 7 years ago

Much of our laws code has been moved into cats-kernel, so this just gets rid of it and uses the stuff from cats-kernel. It's also a win, since cats-kernel has since added more tests!

tixxit commented 7 years ago

I also changed the RingLaws a bit so we only use the non-zero predicate for the actual group laws, but still allow zeros in, eg, the multiplicative monoid laws. I'm not super sure if we want this. The original motivation was really that I was getting scalacheck errors about discarding too many values due to the filtering for tests like combineAll.

codecov-io commented 7 years ago

Current coverage is 67.87% (diff: 91.30%)

Merging #182 into master will decrease coverage by 2.36%

@@             master       #182   diff @@
==========================================
  Files            43         37     -6   
  Lines           904        772   -132   
  Methods         855        726   -129   
  Messages          0          0          
  Branches         49         46     -3   
==========================================
- Hits            635        524   -111   
+ Misses          269        248    -21   
  Partials          0          0

Powered by Codecov. Last update 449c064...3fdc43f

johnynek commented 7 years ago

:+1:

non commented 7 years ago

👍