Why don't we move Spire's Module/VectorSpace/MetricSpace/etc. here?

typelevel / algebra

Experimental project to lay out basic algebra type classes

https://typelevel.org/algebra/

Other

378 stars 69 forks source link

Why don't we move Spire's Module/VectorSpace/MetricSpace/etc. here? #203

Open ctongfei opened 7 years ago

ctongfei commented 7 years ago

I think that these typeclasses should go into Algebra.

johnynek commented 7 years ago

I think we could do this. Would you be interested in opening a PR starting at the bottom of that hierarchy?

ctongfei commented 7 years ago

Thanks :-) I'd be happy to do that.

denisrosset commented 7 years ago

@ctongfei Beware!

I'm currently revising the Spire test suite. The Spire hierarchy has a few inconsistencies; for example, Module pretends to be noncommutative, but actually it is defined in a way that only makes sense for commutative rings. MetricSpace/InnerProductSpace/CoordinateSpace are only valid when the vector spaces are defined on the reals, ...