typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

migrate sbt 1.x #212

Closed xuwei-k closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #212 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #212   +/-   ##
======================================
  Coverage    76.4%   76.4%           
======================================
  Files          42      42           
  Lines         958     958           
  Branches       68      68           
======================================
  Hits          732     732           
  Misses        226     226

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31291e0...bc0d3ec. Read the comment docs.

johnynek commented 6 years ago

looks like my attempt to merge broke everything.

I'm not sure why people let me run projects when I know so little about sbt.

ryan-williams commented 6 years ago

I'm guessing your last comment was meant for #213 @johnynek ?

johnynek commented 6 years ago

@ryan-williams no, I tried to merge the conflict between here and #213 (which I merged). My attempt to do so failed, making the CI read for this PR that had previously been green (but conflicted with master).

ryan-williams commented 6 years ago

Ah I see, the earlier build "failed" due to codecov but passed tests.

It seems like the latest build passed tests but failed MiMa due to the cats upgrade.

I'm trying to figure out how to run the MiMa checks locally atm to mess with it… update: below comment is how to fix the build, I think.

johnynek commented 6 years ago

Thanks y’all. I’ll merge and publish 1.0.0 tomorrow if nothing stops me.

johnynek commented 6 years ago

Thank you @xuwei-k !