Closed vpavkin closed 6 years ago
Merging #213 into master will increase coverage by
2.95%
. The diff coverage is87.09%
.
@@ Coverage Diff @@
## master #213 +/- ##
=========================================
+ Coverage 73.45% 76.4% +2.95%
=========================================
Files 37 42 +5
Lines 776 958 +182
Branches 58 68 +10
=========================================
+ Hits 570 732 +162
- Misses 206 226 +20
Impacted Files | Coverage Δ | |
---|---|---|
...n/scala/algebra/laws/LatticePartialOrderLaws.scala | 70.58% <ø> (ø) |
:arrow_up: |
laws/src/main/scala/algebra/laws/LatticeLaws.scala | 79.36% <ø> (ø) |
:arrow_up: |
laws/src/main/scala/algebra/laws/LogicLaws.scala | 100% <ø> (ø) |
:arrow_up: |
laws/src/main/scala/algebra/laws/RingLaws.scala | 96.45% <ø> (ø) |
:arrow_up: |
laws/src/main/scala/algebra/laws/BaseLaws.scala | 0% <0%> (ø) |
|
laws/src/main/scala/algebra/laws/GroupLaws.scala | 100% <100%> (ø) |
|
laws/src/main/scala/algebra/laws/OrderLaws.scala | 100% <100%> (ø) |
|
...s/src/main/scala/algebra/laws/IsSerializable.scala | 11.11% <11.11%> (ø) |
|
laws/src/main/scala/algebra/laws/package.scala | 71.42% <71.42%> (ø) |
|
laws/src/main/scala/algebra/laws/Rules.scala | 96.87% <96.87%> (ø) |
|
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a17de00...91f600e. Read the comment docs.
@denisrosset @johnynek this is green now, what's my next step (if there's any)?
next step is to publish, let me try....
Thank you!
I tried to publish this but hit some confusing sbt/release/sonatype etc... errors:
[info] Evaluate: signature-staging
[error] Failed to close the repository
[error] Activity close started:2018-02-15T20:33:56.111Z, stopped:
[error] Failed: sources-staging, failureMessage:Illegal POM: /org/typelevel/algebra_2.11/1.0.0/algebra_2.11-1.0.0.pom Duplicated tag: 'scm' (position: START_TAG
seen ...</scm>\n <scm>... @27:10)
[error] Failed: javadoc-staging, failureMessage:Illegal POM: /org/typelevel/algebra_2.11/1.0.0/algebra_2.11-1.0.0.pom Duplicated tag: 'scm' (position: START_TAG
seen ...</scm>\n <scm>... @27:10)
java.lang.Exception: Failed to close the repository
at xerial.sbt.Sonatype$NexusRESTService.closeStage(Sonatype.scala:721)
at xerial.sbt.Sonatype$NexusRESTService.closeAndPromote(Sonatype.scala:820)
at xerial.sbt.Sonatype$SonatypeCommand$$anonfun$22$$anonfun$apply$11.apply(Sonatype.scala:215)
at xerial.sbt.Sonatype$SonatypeCommand$$anonfun$22$$anonfun$apply$11.apply(Sonatype.scala:214)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
I am going to try to get #212 merged and maybe that will fix it. Any one who knows sbt or sbt-release and can help fix would be great.
Lightly interpreting the error msg: it's failing a POM validation because the <scm>
tag appears twice. I can reproduce that locally after running publishLocal
in this repo.
yeah, but I dont see the <scm>
twice in the config. I have a vague memory of working around this in the past, but I don't recall the solution.
@gkk-stripe do you know how to fix?
yea, weird, I have to slightly walk back my claim about a publishLocal
repro. I ran publishLocal
on this PR's branch last night to do some testing against a spire that used it, and when you posted your error I checked and those POMs had two <scm>
tags, but now I can't reproduce that! Will lyk if I find a clue.
@johnynek I assume you must not have been able to get it published, still? I'm in an airport (back on the internet, finally), but I can't publish from here. @denisrosset, do you happen to have any ideas on the SCM issue?
Yeah I haven’t been able to diagnose the scm issue. I don’t recall how I got past it before. I think I complained about sbt until someone who thinks it is good fixed it. I was kind of hoping to do the same here.
@johnynek Want me to take a look at this later this week?
@johnynek published version should be 1.0, correct?
I believe you just need to remove the <scm>
element from pomExtra
. At some point something started adding that automatically. I remember removing it from my projects.
Yeah this change happened when I updated to sbt 1.0 … have you done a release since then? I also updated a bunch of plugins so I'm not sure what exactly triggered it but I guess it doesn't matter. The commit where I finally fixed it has the comment "ffs" so I was pretty unhappy by that point.
I tried commenting out the scm but from the pomInfo but didn’t seem to work. Maybe I forgot to reload in my frustration. I’ll try again.
@vpavkin thanks for picking that stuff! I'm pretty much under water right now, so it's good that this progresses.
My attempt to continue progress on #207.
@johnynek is this all we need ? :)