search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

Updates for 2.13.0-RC1 #228

Closed travisbrown closed 5 years ago

travisbrown commented 5 years ago

This includes @larsrh's commit from #226 and does a few remaining things needed for 2.13, including removing Catalysts (by copy-pasting the platform-checking stuff and scrapping the macro-powered type tag in favor of explicit type names for laws).

I've also gone ahead and updated a few of the sbt plugins and the older Scala versions.

MiMa says it's fine. The new algebra.laws.platform.Platform thing is only Scala-private (you could use it from Java if you really wanted to), but that doesn't seem like a big deal.

I'm doing this because I'd like to have Spire on 2.13. I guess it could wait until everything upstream is out for 2.13.0-RC2, but given that that includes ScalaTest and Cats it could take a while.

r? @larsrh

larsrh commented 5 years ago

Thanks a lot! Seems like bumps for tut and mdoc are still required.

codecov-io commented 5 years ago

Codecov Report

Merging #228 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   76.52%   76.57%   +0.04%     
==========================================
  Files          45       45              
  Lines        1001     1003       +2     
  Branches       43       46       +3     
==========================================
+ Hits          766      768       +2     
  Misses        235      235
Impacted Files Coverage Δ
.../shared/src/main/scala/algebra/laws/BaseLaws.scala 0% <ø> (ø)
...d/src/main/scala/algebra/laws/IsSerializable.scala 11.11% <ø> (ø)
...n/scala/algebra/laws/LatticePartialOrderLaws.scala 70.58% <ø> (ø)
...shared/src/main/scala/algebra/laws/LogicLaws.scala 100% <ø> (ø)
...shared/src/main/scala/algebra/laws/OrderLaws.scala 100% <ø> (ø)
...shared/src/main/scala/algebra/laws/GroupLaws.scala 100% <ø> (ø)
core/src/main/scala/algebra/instances/array.scala 59.25% <ø> (ø) :arrow_up:
...ared/src/main/scala/algebra/laws/LatticeLaws.scala 79.36% <ø> (ø)
...s/shared/src/main/scala/algebra/laws/package.scala 71.42% <ø> (ø)
...red/src/main/scala/algebra/laws/DeMorganLaws.scala 100% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46d7e23...f85ff5d. Read the comment docs.

travisbrown commented 5 years ago

@larsrh mdoc isn't published for any 2.13 versions, so I think it makes sense just to disable the makeMicrosite check in CI (this is what I've done in my other projects). The 2.13.0-RC1 build is also failing because MiMa has no previous artifacts to compare to, so I've also disabled that check. When this is merged I'll open issues to remind us to re-enable these checks when we can.

larsrh commented 5 years ago

Can I get another :+1:? @johnynek?