search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

PartialOrder instance for Set #62

Closed adelbertc closed 9 years ago

johnynek commented 9 years ago

need to add in the test that this follows the PartialOrder laws.

johnynek commented 9 years ago

Also, while we're at it, I think you can make a Lattice instance for Set[A] for which meet is intersection and join is union (or the other way around), which is basically the same as the Semiring instance, but it also follows the Lattice laws.

adelbertc commented 9 years ago

Currently there doesn't seem to be any tests in the project - I am more than happy to start things off by writing the tests for Set though.

Will address your comments in an incoming commit.

johnynek commented 9 years ago

See the laws sub project. It depends on std.

adelbertc commented 9 years ago

Doh, silly me. Will add, thanks!

non commented 9 years ago

:+1:

johnynek commented 9 years ago

Nice work! Thanks.