search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

Add a Mima test for core #68

Closed johnynek closed 5 years ago

johnynek commented 9 years ago

discussed in #18. I think we should be SUPER conservative with algebra-core, which if we succeed with this, could be a dependency of spire, algebird, and transitively scalding and summingbird (perhaps spark would use it if we can gain traction as a stable abstraction for algebraic concepts).

With mima, we could make sure we fail the build if there is any binary compatibility issue with changeds to algebra-core.

We can probably be a bit more free with algebra-std assuming that is less often a direct dependency.

non commented 9 years ago

Sounds good to me. Things are feeling relatively stable, I just opened one issue on core but otherwise I'm pretty satisfied.

sritchie commented 7 years ago

This is done. Can we close @johnynek?

johnynek commented 7 years ago

Yeah, we can. We just need to fix the mima issue, which should be fixable. On Sat, Dec 3, 2016 at 06:29 Sam Ritchie notifications@github.com wrote:

This is done. Can we close @johnynek https://github.com/johnynek?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/typelevel/algebra/issues/68#issuecomment-264649419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJdrDTOuwLaHHDowLZYY3HbRPmTEkpks5rEZjugaJpZM4FT1jL .

sritchie commented 7 years ago

Fixed in my PR now On Sat, Dec 3, 2016 at 1:37 PM P. Oscar Boykin notifications@github.com wrote:

Yeah, we can. We just need to fix the mima issue, which should be fixable. On Sat, Dec 3, 2016 at 06:29 Sam Ritchie notifications@github.com wrote:

This is done. Can we close @johnynek https://github.com/johnynek?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/typelevel/algebra/issues/68#issuecomment-264649419, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAEJdrDTOuwLaHHDowLZYY3HbRPmTEkpks5rEZjugaJpZM4FT1jL

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/typelevel/algebra/issues/68#issuecomment-264663917, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEQA4X4RpSDvRgmNuo_LNHOqoxa4EOxks5rEdMCgaJpZM4FT1jL .