search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

Remove asCommutativeRing from Heyting #94

Closed johnynek closed 8 years ago

johnynek commented 8 years ago

Addresses the issue in #89

non commented 8 years ago

:+1:

TomasMikula commented 8 years ago

Also note that if we had a type BoolRing, it could implement negate (to be negate(x) = x) and then the instance returned from Bool#asCommutativeRing would not have to override negate.

non commented 8 years ago

Let's open an issue about possibly adding BoolRing, and I will submit a PR to fix this bug. (I also want to ensure that we have a test that detects this issue.)

TomasMikula commented 8 years ago

Sounds good, I will open the issue.