search

typelevel / case-insensitive

A case-insensitive string for Scala
Apache License 2.0
37 stars 15 forks source link

Arbitrary[CIString] is extremely slow in v1.4.0 #442

Closed bpholt closed 1 month ago

bpholt commented 1 month ago

The Arbitrary[CIString] instance published in case-insensitive-testkit v1.4.0 is extremely slow. Running the MonoidTests[Map[CIString, String]].monoid tests from cats-laws takes 4–5 minutes on my computer with v1.4.0. This was fixed in 7f27b01, and using the snapshot published when that was merged improves the runtime on those law tests to 3–4 seconds.

Could we publish a v1.4.1 with that change (and possibly everything up to the Scala Native 0.5 update in #431)? I think it would be tagged on either 713ccf0 (because that's the merge commit for 7f27b01) or 12875f1 (because that's the merge immediately preceding #431).

bpholt commented 1 month ago

Here's an example of code that could benefit from a v1.4.1: https://github.com/typelevel/natchez/pull/1071

rossabaker commented 1 month ago

https://github.com/typelevel/case-insensitive/releases/tag/v1.4.1

bpholt commented 1 month ago

Thanks @rossabaker!

bpholt commented 1 month ago

@rossabaker it looks like the build failed for that release… 😢

rossabaker commented 1 month ago

Should be fixed as 1.4.2.