typelevel / catbird

Birds and cats together
http://catbird.io
Apache License 2.0
139 stars 22 forks source link

Setup MiMa for finagle #430

Closed armanbilge closed 1 year ago

armanbilge commented 2 years ago

Give it a try with rootFinagle/mimaReportBinaryIssues :)

codecov-commenter commented 2 years ago

Codecov Report

Merging #430 (976e505) into main (e1b9fc2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files           7        7           
  Lines         124      124           
  Branches        2        2           
=======================================
  Hits          112      112           
  Misses         12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bpholt commented 2 years ago

This is pretty cool. Looking forward to trying it out for real when they update upstream—hopefully it will be able to tell us whether whatever version is next (I was expecting 22.5.0, but you'd think that would be been released by now) is compatible with 22.4.0.

bpholt commented 1 year ago

I tried setting val versions = Seq("22.7.0", "22.4.0") in FinaglePlugin. Running rootFinagle/mimaReportBinaryIssues reported 89 issues, which indicates that v22.7.0 is not bin-compatible with v22.4.0. (Looking at the "Breaking API Changes " in its release notes, I think that's right!)