typelevel / catbird

Birds and cats together
http://catbird.io
Apache License 2.0
139 stars 23 forks source link

Update Finagle to 23.11 #573

Open milanvdm opened 1 year ago

milanvdm commented 1 year ago

@bpholt Found the following MiMa issues:

[error] finagle-core: Failed binary compatibility check against com.twitter:finagle-core_2.12:23.11.0! Found 2 potential problems
[error]  * class com.twitter.finagle.context.Requeues does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.context.Requeues")
[error]  * object com.twitter.finagle.context.Requeues does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.context.Requeues$")

From what I can tell, these are not an issue. But that does mean I need to drop the 22.12.0 version in the MiMa check.

bpholt commented 1 year ago

Yes, that sounds right.

Someday I'd like to introduce a scheme like I added to my company's async-utils library, where we publish different artifacts of catbird linked against each of several older versions of Finagle/Twitter Utils, but since we haven't really been introducing new features to catbird, I don't think that's pressing. (If there were new features included in the upcoming release, it would force users to also update their Twitter versions, which isn't always trivial.) For now I think we can update the upstream MiMa check and then we'll publish v23.11.0.

milanvdm commented 1 year ago

@bpholt Done! :)

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1043ccd) 90.60% compared to head (a70d912) 90.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #573 +/- ## ======================================= Coverage 90.60% 90.60% ======================================= Files 18 18 Lines 298 298 Branches 2 2 ======================================= Hits 270 270 Misses 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milanvdm commented 11 months ago

@bpholt Kind reminder! :)

milanvdm commented 8 months ago

@bpholt Could I get an approval on this? :)

nickrsabol commented 5 months ago

@bpholt is there any intention on merging this please?

nickrsabol commented 5 months ago

Hi @bpholt thank you for your efforts in maintaining this project. It is used widely by teams at my company with great success. We are currently upgrading our dependencies on Finagle and are unable to do so until this project is brought up to date as well. Could this pull request please get merged so that we can make progress?

milanvdm commented 5 months ago

@nickrsabol Ive raised this with Typelevel and hopefully get this merged :)

bpholt commented 5 months ago

I'd like to spend some time on this this week, so we can resolve those MiMa issues without dropping the version from the check. Can we hold off on merging until that's done?

bpholt commented 5 months ago

See #607 for some progress I made on this today. If that's deemed an acceptable approach, then once it's merged, we can add 23.11 to the list of supported Finagles.