search

typelevel / cats-collections

Data structures for pure functional programming in Scala
https://typelevel.org/cats-collections/
Other
556 stars 98 forks source link

Would you accept an immutable list implementation of Okasaki #151

Closed johnynek closed 5 years ago

johnynek commented 5 years ago

see:

https://gist.github.com/johnynek/5f4f97772595e2f65092cf51d186d6f2

it's a lot of work for everyone to send a complete PR. I want to get an idea if this is interesting to the maintainers before I do.

Alternatively, anyone is free to copy all or any of my code to send an implementation.

larsrh commented 5 years ago

Pending some tests and a more thorough review, I'd be in favour of inclusion. I appreciate your work.

On 27 December 2018 18:55:03 CET, "P. Oscar Boykin" notifications@github.com wrote:

see:

https://gist.github.com/johnynek/5f4f97772595e2f65092cf51d186d6f2

it's a lot of work for everyone to send a complete PR. I want to get an idea if this is interesting to the maintainers before I do.

Alternatively, anyone is free to copy all or any of my code to send an implementation.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/typelevel/cats-collections/issues/151

larsrh commented 5 years ago

Merged.

johnynek commented 5 years ago

Thank you!