search

typelevel / cats-effect

The pure asynchronous runtime for Scala
https://typelevel.org/cats-effect/
Apache License 2.0
2.01k stars 514 forks source link

`raceOutcome` is not tested (directly) #2552

Open armanbilge opened 2 years ago

armanbilge commented 2 years ago

... and laws/tests :)

Slipped a fix in here, but probably deserves its own PR: https://github.com/typelevel/cats-effect/pull/2545/commits/bdc7429e6b333500a07d357b7dbe783f34aeee26#diff-5acd9e5b3bc8897d205aa4590f18c307679d41279ca72a125764900fffe9d568

Discord discussion: https://discord.com/channels/632277896739946517/839263556754472990/910242079341412433

Related: https://github.com/typelevel/cats-effect/pull/1392

vasilmkd commented 2 years ago

Removing this from the milestone because it is not a blocker and the fix is part of another PR.

armanbilge commented 2 years ago

The fix went through in https://github.com/typelevel/cats-effect/pull/2545, but we are still lacking laws/tests.

djspiewak commented 2 years ago

Let's leave this issue open to track the lack of tests