search

typelevel / cats-effect

The pure asynchronous runtime for Scala
https://typelevel.org/cats-effect/
Apache License 2.0
2.02k stars 517 forks source link

Document usage of `-Wnonunit-statement` #4054

Closed froth closed 4 months ago

froth commented 5 months ago

fixes #3646

I will open another pull request against the g8 template adding the warning.

froth commented 5 months ago

CI failure seems unrelated

froth commented 5 months ago

Thanks for the review, I pushed changes :)

froth commented 4 months ago

@durban is there anything else to be done here from my side? Just to make sure I don't forget that I opened this ;)

durban commented 4 months ago

@froth Not at all. We're just slow ;-)

In fact, this seems like a simple case, so I'll merge this PR this weekend, unless another maintainer objects (or merges it first).