typelevel / cats

Lightweight, modular, and extensible library for functional programming.
https://typelevel.org/cats/
Other
5.26k stars 1.21k forks source link

Update nscplugin, sbt-scala-native to 0.5.1 #4585

Closed typelevel-steward[bot] closed 6 months ago

typelevel-steward[bot] commented 7 months ago

About this PR

📦 Updates

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

âš™ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scala-native" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scala-native" } }] ```

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

satorg commented 7 months ago

Seems blocked by typelevel/discipline#446,

satorg commented 6 months ago

+ Update scalacheck to 1.18.0 + Update discipline-core to 1.7.0 + Update discipline-munit to 2.0.0-M4

satorg commented 6 months ago

Ok, the checks are passing now 🎉 @armanbilge @mpilquist could you verify that tlVersionIntroduced and other settings are properly re-aligned here in the PR please? Thank you!

armanbilge commented 6 months ago

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

https://github.com/typelevel/cats/blob/dfd9559a5d8c4f0a8f2d8e4818b52f21fb7a7ba7/tests/native/src/test/scala/cats/native/tests/FutureSuite.scala#L40-L41

Probably we can now share that suite between JVM and Native.

Thanks!

kapunga commented 6 months ago

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

https://github.com/typelevel/cats/blob/dfd9559a5d8c4f0a8f2d8e4818b52f21fb7a7ba7/tests/native/src/test/scala/cats/native/tests/FutureSuite.scala#L40-L41

Probably we can now share that suite between JVM and Native.

Thanks!

Wasn't sure if anyone was working on this so I went ahead and opened a PR: https://github.com/typelevel/cats/pull/4601

danicheg commented 6 months ago

Shall we publish a fresh release?

mpilquist commented 6 months ago

@armanbilge and I were discussing a release plan yesterday on Discord. He suggested a Cats 2.11.0 release against Native 0.4 and then an immediate Cats 2.12.0 release against Native 0.5. To do so, we'll have to temporarily downgrade native on main branch.

armanbilge commented 6 months ago

To do so, we'll have to temporarily downgrade native on main branch.

Not necessarily. We can tag 3c7474b3827cfc4605259698350ddc2c7b5bf994 (the commit prior to merging this PR) as v2.11.0. The v2.11.0 release will be missing any PRs that were merged after, such as https://github.com/typelevel/cats/pull/4602.

satorg commented 6 months ago

The v2.11.0 release will be missing any PRs that were merged after

Actually, there were exactly two of them:

armanbilge commented 6 months ago

Right, but https://github.com/typelevel/cats/pull/4605 would be unable to land in v2.11.0 anyway :)

sideeffffect commented 5 months ago

Hello good people here, may I ask what did you do to fix/workaround the problem with

finished with non-zero value 139

https://github.com/typelevel/cats/pull/4585#pullrequestreview-2065130233 ?