search

typelevel / scala

Typelevel Scala, a fork of Scala
http://typelevel.org/scala/
372 stars 21 forks source link

A warning should be issued when defining an implicit def with multiple non-implicit parameters #89

Closed propensive closed 8 years ago

propensive commented 9 years ago

These serve very little purpose, unless code is somewhere requesting a Function2[X, Y, Z], which doesn't seem like a great idea. The user probably intended to make the parameters implicit.

milessabin commented 9 years ago

I don't think it's unreasonable to define and request an implicit value of some non-unary function type. It's maybe not that common, but I don't think that's enough of a reason to complain.

propensive commented 9 years ago

Ok, I'll close this if nobody else has been burned (I wasted, oh, a good 20 seconds...) by this.

SethTisue commented 9 years ago

perhaps should be an Abide rule?

milessabin commented 8 years ago

I think nearly two years is long enough to wait for someone to speak up for this ;-) Closing ...