search

typelevel / skunk

A data access library for Scala + Postgres.
https://typelevel.org/skunk/
MIT License
1.59k stars 163 forks source link

Add completions: alter role, create/alter/drop policy, comment, analyze, alter function #1039

Closed rolang closed 9 months ago

rolang commented 9 months ago

Support for completions:

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3f99149) 85.54% compared to head (f0f2008) 85.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1039 +/- ## ========================================== + Coverage 85.54% 85.58% +0.04% ========================================== Files 135 135 Lines 2041 2047 +6 Branches 239 245 +6 ========================================== + Hits 1746 1752 +6 Misses 295 295 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mpilquist commented 9 months ago

Looks good! Mind retargeting the PR to series/0.6 branch? After PR is merged to series/0.6, I'll merge to main as well so we pick up changes in both 0.6 and 1.0.

rolang commented 9 months ago

Looks good! Mind retargeting the PR to series/0.6 branch? After PR is merged to series/0.6, I'll merge to main as well so we pick up changes in both 0.6 and 1.0.

ok, I tried to re-target it in the same PR, but it got closed after I re-created the branch based on 0.6.x and can't reopen it :D. Created a new PR instead: https://github.com/typelevel/skunk/pull/1041