search

typelevel / skunk

A data access library for Scala + Postgres.
https://typelevel.org/skunk/
MIT License
1.59k stars 163 forks source link

Update otel4s to 0.5.0-RC2, use `otel4s-sdk` in tests #1054

Closed iRevive closed 8 months ago

iRevive commented 9 months ago

The otel4s-sdk-* modules provide a cross-platform implementation of the SDK API.

The traces seem consistent across platforms:

JVM ![image](https://github.com/typelevel/skunk/assets/6395483/2e675336-bb60-4088-9b1e-d8e3e1aec3f2)
JS ![image](https://github.com/typelevel/skunk/assets/6395483/693d90a1-e40b-4f60-a480-2e9571a55bab)
mpilquist commented 8 months ago

@iRevive Timing wise, is it worth preparing a separate PR (or building on #1053) that doesn't yet use the SDK? Or do you expect the SDK to be released soon enough after 0.5.0 final that we can do it all at once?

iRevive commented 8 months ago

Hopefully, we will get a release this week. Here are the details: https://github.com/typelevel/otel4s/discussions/511#discussioncomment-8749921.

mpilquist commented 8 months ago

Awesome, thanks! +1 on including in 0.5.0 release.

iRevive commented 8 months ago

I updated otel4s to 0.5.0-RC2.

mpilquist commented 8 months ago

Awesome, thanks!!