search

typelevel / steward

Runs Scala Steward for Typelevel projects
5 stars 10 forks source link

Cats 2.12 upgrades? #53

Open rossabaker opened 6 days ago

rossabaker commented 6 days ago

Was something done to stifle Cats 2.12.0 PRs? There are a lot of projects with broken Native PRs because they got 2.11.0 but were never offered 2.12.

Example: https://github.com/typelevel/cats-mtl/pull/573

djspiewak commented 2 days ago

I'm very confused as to what this means?

rossabaker commented 2 days ago

The Cats version on that project is 2.11.0. It never received a pull request from Scala Steward for 2.12.0. That PR -- and many like it -- are failing because there's no Scala Native for that version of Cats. They could probably be made green by also upgrading to Cats 2.12.0.

The question here is, why didn't Steward notice there's a Cats 2.12.0?

djspiewak commented 2 days ago

Ahhhh interesting question.

armanbilge commented 1 day ago

(edit: my hypothesis, I'm not an expert on steward implementation)

It's not offered Cats 2.12 because there is no Cats 2.12 for Scala Native 0.4, which that project is currently on.

Because Cats 2.12 and Scala Native 0.5 must go hand-in-hand, this situation must be resolved manually. Steward does not know that those updates must happen in the same PR.

mzuehlke commented 21 hours ago

It's not offered Cats 2.12 because there is no Cats 2.12 for Scala Native 0.4, which that project is currently on.

Thats sound like a very likely explanation.