search

typelevel / typelevel-nix

Development tools for Typelevel projects
Apache License 2.0
109 stars 12 forks source link

Additional maintainer(s) #15

Closed rossabaker closed 2 weeks ago

rossabaker commented 2 years ago

I like to have at least two maintainers on Typelevel projects. This one shouldn't be too burdensome. Volunteers?

domenkozar commented 1 year ago

As part of https://devenv.sh I added Scala tooling, maybe if you're interested it would be better to maintain it there?

https://github.com/cachix/devenv/pull/60

rossabaker commented 1 year ago

That's a neat project. There's some nuance in supporting Scala:

We handle all of that through configuration options. Do you see the devenv language support modules as a starting point, or are you looking to keep them as simple booleans?

domenkozar commented 1 year ago

We now support a number of java versions: https://devenv.sh/reference/options/#languagesjavaenable

Probably scala should just enable java support as well?

Hopefully that answers your question around configuration options.

rossabaker commented 1 year ago

That answers my question about whether there's more than languages.whatever.enable.

We generally want our sbt to have a specific JDK, and having Scala Native support implies at least two, usually three extra packages. The C support in devenv is gcc, and we need clang.

So I think that's all to say that it could work, but that to keep parity with what's here, the Scala config would need a lot more options.

domenkozar commented 1 year ago

I'm happy to move over maintenance if we get a list of the options we need for scala :)

domenkozar commented 1 year ago

@rossabaker I've made changes so that we add clang and languages.scala.enable now enables languages.java.enable where the SDK can be configured.

domenkozar commented 1 year ago

There should be proper propagation of jre package now: https://github.com/cachix/devenv/pull/309/files

softinio commented 2 weeks ago

I like to have at least two maintainers on Typelevel projects. This one shouldn't be too burdensome. Volunteers?

Happy to volunteer to help with this one.

samspills commented 2 weeks ago

@softinio I have added you to to the Typelevel/nix team, thank you!

rossabaker commented 2 weeks ago

Thanks, @softinio! Now that we're back to two-deep, closing this.

softinio commented 2 weeks ago

@samspills @rossabaker Thank you both!