search

typelevel / typelevel-nix

Development tools for Typelevel projects
Apache License 2.0
109 stars 12 forks source link

Update documentation + reenable NodeJS in `library` shell by defualt #16

Closed amesgen closed 2 years ago

amesgen commented 2 years ago

Forgot to do this in #14 😿

rossabaker commented 2 years ago

Hmm... should that JS provisioning default to true? It's a breaking change if it doesn't. And I'd say in a vacuum, probably yes for libraries and no for applications? I didn't think about that on the other PR.

amesgen commented 2 years ago

Yes, #14 was a breaking change, probably should have mentioned that. I would be fine with returning to nodejs.enable = true; for libraries, should I amend it here?

rossabaker commented 2 years ago

:+1: That'd be great. Sorry I didn't catch that on #14. I'm mostly glad to have the option.