search

typelevel / typelevel-nix

Development tools for Typelevel projects
Apache License 2.0
109 stars 12 forks source link

Gate NodeJS support behind an option? #2

Closed amesgen closed 2 years ago

amesgen commented 2 years ago

EDIT see next comment

Extremely minor nitpick: Currently, the default NodeJS version is printed unconditonally as part of the devshell MOTD:

https://github.com/rossabaker/typelevel-nix/blob/f0712172fcb658e2032deb771aec58e3c9f8a13c/modules/typelevelShell.nix#L53

For projects which do not require NodeJS this might be a bit confusing maybe?

amesgen commented 2 years ago

Ok I just saw that nodejs and yarn are added as packages unconditonally, so the scope of this issue should rather be to decide whether to put this behind an enable flag.

rossabaker commented 2 years ago

I had considered adding a flag. I think it's a good idea.