typelevel / weaver-test

A test framework that runs everything in parallel.
https://typelevel.org/weaver-test/
Other
48 stars 8 forks source link

DogFoodTests does not correctly check timestamps for logs #105

Open zainab-ali opened 3 weeks ago

zainab-ali commented 3 weeks ago

This issue was copied over from: https://github.com/disneystreaming/weaver-test/issues/332 It was opened by: amumurst


Running sbt -mem 8192 test locally this tests fails.

[info] welcome to sbt 1.5.4 (AdoptOpenJDK Java 1.8.0_282)
.....
[info] *************FAILURES**************
[info] weaver.framework.test.DogFoodTests
[info] - test suite outputs logs for failed tests 2s
[info]   Values not equal: (modules/framework/cats/test/src/DogFoodTests.scala:84)
[info] 
[info]   - failure 0ms                                               |  - failure 0ms
[info]     expected (src/main/DogFoodTests.scala:5)                  |    expected (src/main/DogFoodTests.scala:5)
[info]                                                               |  
[info]       [INFO]  [11]:54:35 [DogFoodTests.scala:5] this test     |      [INFO]  [12]:54:35 [DogFoodTests.scala:5] this test
[info]       [ERROR] [11]:54:35 [DogFoodTests.scala:5] has failed    |      [ERROR] [12]:54:35 [DogFoodTests.scala:5] has failed
[info]       [DEBUG] [11]:54:35 [DogFoodTests.scala:5] with context  |      [DEBUG] [12]:54:35 [DogFoodTests.scala:5] with context
[info]           a       -> b                                        |          a       -> b
[info]           token   -> <something>                              |          token   -> <something>
[info]           request -> true                                     |          request -> true

I am located in

Standard time zone:     UTC/GMT +1:00 hour
Daylight saving time:       +1:00 hour
Current time zone offset:   UTC/GMT +2:00 hours
Time zone abbreviation:     CEST
zainab-ali commented 3 weeks ago

This comment was copied over from: https://github.com/disneystreaming/weaver-test/issues/332#issuecomment-905439680 It was written by: keynmol


Timezones, my old nemesis!

I'll have a think on how to make those tests less problematic.