search

typelift / SwiftCheck

QuickCheck for Swift
MIT License
1.42k stars 106 forks source link

Provide non-DSL spellings of primitives #262

Closed CodaFi closed 6 years ago

CodaFi commented 6 years ago

What's in this pull request?

261 requests a way to spell the testing primitives without using the DSL.

What's worth discussing about this pull request?

Operators in Swift have a complex and storied history, and their use outside of the standard library is the subject of a lot of styling debates. Many frameworks that choose to provide custom operators do so because they are trying to mimic a particular syntax or structure. The trap many fall into is not providing a way out of the DSL.

What downsides are there to merging this pull request?

On the other hand, SwiftCheck's DSL isn't just a matter of syntax. Tests are data in this framework, and can be stored and computed with. <- indicates when you want to statement-ize that data and execute the test. Providing an out dilutes that philosophy.

CodaFi commented 6 years ago

@alexhuang91 I'm unable to tag you as a reviewer, but I would still like you to review this.

CodaFi commented 6 years ago

⛵️