search

typelift / Swiftx

Functional data types and functions for any project
BSD 3-Clause "New" or "Revised" License
219 stars 28 forks source link

Initial port to Swift 4 #67

Closed tcldr closed 6 years ago

tcldr commented 7 years ago

What's in this pull request?

Initial migration of library to Swift 4. (Minor changes but lib required by Swiftz which has more extensive changes)

Why merge this pull request?

Migrates library to latest version of Swift. All tests passing with the Swift 4 version of SwiftCheck that I submitted as a PR earlier.

What's worth discussing about this pull request?

This PR focuses on getting the build compiling without warning and passing all tests. I will have missed anything not picked up by these! There may be some wider changes you have in mind to take advantage of Swift 4.

What downsides are there to merging this pull request?

Uses temporary refs to my personal SwiftCheck forks with Swift 4 migration. Will need updating to point to official SwiftCheck repos.

bkase commented 7 years ago

Alright, I merged the SwiftCheck PR -- so now we can point to that and then we can merge this one!

tcldr commented 7 years ago

Nice one. I've updated Operadics to SPM v4 too. Once that's in we can cascade the rest up!

CodaFi commented 7 years ago

Xcode 9 redid the file paths so they match the project structure. This is undesirable given that I would like to support just a package build in the future. Could you please try to keep everything in their original positions (modulo moving things into the target directory)?

CodaFi commented 6 years ago

Resolved by the merge of #68