Plugin thesaurus

[ghost]

Thanks for the clarification and the offer for my backlink in 167: if I need it I will keep it in mind, for now I sincerely thank you.

• In visual environment when inserting a notice, if you press the red button before entering text, an error is obviously detected on the length of the object. It may happen to an inexperienced user to press the button too early.

• I have a doubt about the description string on line 313 of the cyanine.yaml file. Is the word 'a11y' correct or a typo? I am writing to you because I just pushed some translations related to the new theme, both in the user and admin environment, and in doubt I preferred to leave the text unchanged.

• Another small problem: the new theme is missing a favicon.

• Finally a clarification, reading [Deployment Checklist] (https://github.com/typemill/typemill/issues/67) I see the format of the description required for the commits that I would gladly use but I have the doubt of what the next version could be. The doubt remains even after reading the [Typemill Roadmap] (https://github.com/typemill/typemill/issues/35). Among other things, you may find my modification: by mistake I made the checkbox of version 1.3.7 true but I restored the original situation ... :)

(Different requests in the same tichet? Maybe you don't like it, because I see that you open a ticket for every single problem for yourself. For the future, if you like single tickets for single issues, I adapt.)

[trendschau]

Hi iusvar,

thank you!

• You are right, I will improve with the next release.
• "a11y" is probably not accessible so "accessibility" would be more apropriate. I will change it.
• Favicons are not part of a theme anymore, because users can upload their own favicon in the system settings. I think I deleted it from the old typemill theme as well some time ago.
• The deployment checklist and the roadmap are bit outdated, I have to actualize it (and other stuff like documentation, themes, plugins and more). Next release will be Version 1.3.8: Roles and rights. I will try to add an ACL library and improve user management.

In general I prevery 1 ticket for 1 issue so it is easier to close and track them. But totally fine to make exceptions from a rule :D

[ghost]

Hi trendschau,

I was the one who didn't know the acronym a11y, in the translation it's still accessible, I didn't know it meant "accessibility". If you want you can leave it as it is.

For the favicon it's my mistake, I hadn't noticed.

For the versions, excellent, up to 1.3.8, I add it too.

I will immediately make another exception to the rule: I have just uploaded a first plugin thesaurus. If you have time I would be pleased if you took a look at it for an opinion

[trendschau]

It looks awesome! But i did not get it to work yesterday because sqlite3 was missing on my machine. I will try again this evening.

[ghost]

I just added an alternative to sqlite3: after setting the plugin you can use the original dat file (I only changed the filenames)

[trendschau]

I tested it and it works great!! To be honest, I did never try to use a plugin to inject some functionality into the raw editor, that is pretty fantastic, because it might also be possible to create a plugin with a code-editor for the raw mode. So I really love it!

I found only two notices in the response from the xhr-call:

Notice: Constant DS already defined in /var/www/html/typemill/system/Translations.php on line 9

Notice: A non well formed numeric value encountered in /var/www/html/typemill/plugins/thesaurus/index.php on line 43

And I am not sure if the very generic variables in the script.js like "start" or "end" will interfer with other plugins soon, maybe it is better to use some plugin-special prefixes like "thesaurus-start" or something like that?

[ghost]

I'm glad you like it, always for the raw environment I'm also doing other things, a simple counter of characters, words, sentences and time to read the text.

I became interested in this environment because the content is concentrated in a single html container. But my intention is to make both the thesaurus plugin and the counter plugin available in both environments.

I really thank you for the feedback regarding the warnings: I'll take a look.

For the names of the start and end variables you are absolutely right, I will use this advice as a rule to follow for something else.

Also, I think I have never written it, I appreciate the work you are doing with Typemill, really excellent.

[ghost]

The first warning I have already solved with the commit restores uniformity

For the second warning I proceeded by changing from $number = $pieces[1]; to $number = intval($pieces[1]);

Thanks

[trendschau]

Thank you very much for your kind words!

Let me know when it is ready for production, I can add it to the plugin directory next week if it is fine for you

[ghost]

Okay for me, so thank you.

[trendschau]

sorry, I had a lot of family business, but now I am back at work and will add the great plugin to the plugin directory this week :)

[ghost]

no problem, do it when you can, and thanks again :-)

[trendschau]

Hi iusvar,

I added the plugin to the plugin-directory now: https://plugins.typemill.net

Not 100% sure but in my tests with the current release 1.3.7.1 it still produced some errors:

• A notice that constant "DS" is defined already. We could define that constant in the core system file, but overall I want to avoid using constants because of those effects
• Not sure if it is related but when I select some thesaurus, then it sometimes does not change replace the word in the editor. I did not find out a rule so far.

Anyway, thank you for this great contribution :)

[ghost]

Hi trendschau,

Thanks for doing it.

For the first point, I had already restored the use of DIRECTORY_SEPARATOR with the commit restores uniformity in develop (which I imagine will be combined with master in the next version).

For the second, I will go into the matter.

it's nice to be able to add functionality to your very useful project :)

[trendschau]

Hi iusvar,

thank you, yes, it will be published with next release, but next release (acl/user-management) will probably take some time :)

[ghost]

As long as it takes, the next release will be another important step, good job :)

[ghost]

Hi trendschau,

I have just made a small change, version 1.0.2, which I believe can resolve what you have reported to me.

In this regard, helping me with an image, I will illustrate the functionality that the plugin should follow.

The synonyms of the chosen word appear in the selected part in green. By positioning the mouse over each of these words, the words relating to the synonym on which the mouse pointer is located appear in the selected part in red: the modification takes place only if you click on the words displayed in the part colored in red. When I say ON THE WORD I mean EXCLUSIVELY ON THE WORD, and not on the white space because in this case the windows disappear without any change. The window disappears even if you click on the part selected in green.

I hope I have expressed it in decent English.