typemill / typemill

Typemill is a lightweight, flat-file CMS designed for simple, fast, and flexible website and eBook creation using Markdown.
https://typemill.net
MIT License
427 stars 60 forks source link

Mail plugin form should have autocomplete set as off #366

Closed jasonday closed 1 year ago

jasonday commented 1 year ago

image

Because chrome (or other password managers) save credentials, those credentials get automatically filled into the username and password fields of the SMTP section of the Mail plugin. So, anytime I go in to any plugin settings, I have to remember to clear these fields, otherwise I receive an error.

Adding autocomplete="off" to the form or to the individual fields would prevent this issue.

`

jasonday commented 1 year ago

Unfortunately, setting "autocomplete: off" in the mail yaml, doesn't solve it.

Digging further, chrome ignores autocomplete in specific scenarios.

To fix, the Mail yaml needs to be changed to:

        username:
          type: email
          label: Username of your mail-account
          placeholder: My Username
          autocomplete: off

        password:
          type: password
          label: Password of your mail-account
          autocomplete: new-password
jasonday commented 1 year ago

@trendschau it would be great if the plugins were in a repo, so that members could contribute fixes and new plugins.

trendschau commented 1 year ago

Thank you!

Most of the plugins are here: https://github.com/typemill-resources and on the plugin page there are links to repos from other users: plugins.typemill.net

jasonday commented 1 year ago

https://github.com/typemill-resources/mail/pull/1

trendschau commented 1 year ago

Thank you, works great, I merged and published a new version.