prettier should be enforced in circleci - Githubissues

typeorm / typeorm

ORM for TypeScript and JavaScript. Supports MySQL, PostgreSQL, MariaDB, SQLite, MS SQL Server, Oracle, SAP Hana, WebSQL databases. Works in NodeJS, Browser, Ionic, Cordova and Electron platforms.

http://typeorm.io

MIT License

33.6k stars 6.22k forks source link

prettier should be enforced in circleci #10866

Open RohanTalip opened 1 month ago

RohanTalip commented 1 month ago

Issue description

prettier should be enforced in circleci

Expected Behavior

prettier formatting should be enforced in circleci, perhaps via prettier --check or some other mechanism.

Actual Behavior

prettier formatting is not currently enforced in circleci.

There are already some files that are in the master branch that are changed when prettier is run on them.

Steps to reproduce

Check out the master branch
Run npm run format

My Environment

Dependency	Version
Operating System	macOS
Node.js version	x.y.zzz
Typescript version	x.y.zzz
TypeORM version	x.y.zzz

Additional Context

No response

Relevant Database Driver(s)

[ ] aurora-mysql
[ ] aurora-postgres
[ ] better-sqlite3
[ ] cockroachdb
[ ] cordova
[ ] expo
[ ] mongodb
[ ] mysql
[ ] nativescript
[ ] oracle
[ ] postgres
[ ] react-native
[ ] sap
[ ] spanner
[ ] sqlite
[ ] sqlite-abstract
[ ] sqljs
[ ] sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, but I don't know how to start. I would need guidance (more on the circleci side).