ES2022 Repository create method include undefined field that breaks DB update

mbagsik00 commented 1 year ago

Issue Description

repository.create() includes the undefined field which breaks the DB update query when using ES2022 as a target in tsconfig

Expected Behavior

Previously we're using es6 as a target for tsconfig and the field that we didn't pass in the repository.create() will not be included in the response.

// Entity
class TestEntity {
  @PrimaryGeneratedColumn('uuid')
  id: string;

  @Column('varchar')
  name: string;
}

// Repository Create
const result = Repository.create({
   name: 'test name'
})

// Result when using ES6
{
 name: 'test name'
}

Actual Behavior

When using ES2022 as a target in tsconfig it returns all the fields that are declared in the entity and sets the value to undefined for the fields that don't exist in the object when creating the repository. This causes some issues when doing an update since it sets other fields to null if we don't include the field in the repository creation. I know we can easily fix this by adding all the fields when creating the repository but didn't expect this to break.

// Entity
class TestEntity {
  @PrimaryGeneratedColumn('uuid')
  id: string;

  @Column('varchar')
  name: string;
}

// Repository Create
const result = Repository.create({
   name: 'test name'
})

// Result when using ES2022
{
 id: undefined,
 name: 'test name'
}

Steps to Reproduce

Create a repository using only some of the fields from the entity.
Result returns the other fields from the entity that haven't been declared when creating the repository with an undefined value.

My Environment

NestJS

Dependency	Version
Operating System	MacOS
Node.js version	16.15.0
Typescript version	4.6.2
TypeORM version	0.2.25

Additional Context

I'm not sure if ES2022 is supported or not yet.

Relevant Database Driver(s)

DB Type	Reproducible
`aurora-mysql`	no
`aurora-postgres`	no
`better-sqlite3`	no
`cockroachdb`	no
`cordova`	no
`expo`	no
`mongodb`	no
`mysql`	no
`nativescript`	no
`oracle`	no
`postgres`	yes
`react-native`	no
`sap`	no
`spanner`	no
`sqlite`	no
`sqlite-abstract`	no
`sqljs`	no
`sqlserver`	no

Are you willing to resolve this issue by submitting a Pull Request?

✖️ Yes, I have the time, and I know how to start.
✅ Yes, I have the time, but I don't know how to start. I would need guidance.
✖️ No, I don’t have the time, but I can support (using donations) development.
✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.