search

typeplate / typeplate.github.io

Official Website for Typeplate: “A Typographic Starter Kit.”
http://typeplate.com
Other
1.35k stars 109 forks source link

LESS Port Update for 1.0.2 #102

Closed grayghostvisuals closed 11 years ago

grayghostvisuals commented 11 years ago

We need to update the LESS port to match our current Sass file. https://github.com/typeplate/typeplate.github.com/tree/development/typeplate/scss

We're using the !default flag to allow authors to define custom var values before the actual typeplate.scss file. Apparently this can be done with the Stylus port so we hope this can be doable with LESS.

mchambaud commented 11 years ago

Hey! I will have to do some research to see if this is possible.

grayghostvisuals commented 11 years ago

Yeah, kinda thought so. If you can match the new hotness of the Sass file with the LESS file as best as possible that would be peachy! You hold the torch for all LESS users. Thanks dude!

mchambaud commented 11 years ago

There is no keywords to do this.

I've successfully accomplished a variable override by importing a typeplate-vars.less at the end of the variables sections.

Another (a better) solution would be to forget about overriding completely and simply put all the vars in a separate file which could be modified by the user, much like Twitter Bootstrap did.

mchambaud commented 11 years ago

https://github.com/mchambaud/typeplate.github.com/commit/dea691fb36282d204d49a83133a0c5ade2601b3a

grayghostvisuals commented 11 years ago

Yeah the only problem with the bootstrap method is the bower integration we provide. I want devs to be able to port it into their projects simply with bower and not have to provide any variables or import an additional file to get going (also bower overwrites any files in the components directory that is changed by the author upon updating the package contents).

For those that want customization I want to provide a vars file to duplicate and override the defaults outside the bower package. I understand your concerns, but this is a much better method when dealing with package mgt. especially with bower.

grayghostvisuals commented 11 years ago

wooops! hit the panic button there

mchambaud commented 11 years ago

Ahhhh, yes I understand.

I will try to figure out something and I might even fork LESS and look into adding this feature!

grayghostvisuals commented 11 years ago

Awesome sauce and yeah, that would definitely rock for LESS users. I would try and sway you towards Sass myself, but don't wanna mingle in others chosen work tools and prefs. :)

grayghostvisuals commented 11 years ago

Hey @mchambaud

Sadly Zak and I have decided to cut loose the Stylus and LESS port of Typeplate. Thanks for you eagerness to help out though. Much appreciated :metal:

mchambaud commented 11 years ago

This is unfortunate, I'm sorry I could not find a solution for this problem :(

Maybe it is time I switch to SCSS.