Open ldexterldesign opened 11 years ago
If you would like to strictly build this as a function for our Sass port I'd be willing to cater the idea. What do you think @zakkain ?
Currently trying to shoehorn https://github.com/thoughtbot/bourbon/commit/5bdaa07c0fcfa6f1e3507185fa805741eeb33952 into http://typeplate.com/ , but it's not going well :Z
Let's get Zak's opinion too before you go any further. Also a reminder if you do go through with this to make sure you work on it through a sep branch per our README.
NP, let me know ;)
Kind thanks,
PS I don't believe https://github.com/thoughtbot/bourbon/pull/175 outputs rem/px fallbacks functionality, which is a nice feature in yours (I'll ping https://github.com/plapier a line now and hopefully he can corroborate that?)
I'd like to see an example of the code in this thread as well before proceeding with it in the project itself. I've also noted in the new README of the development branch the Modular Scale gem by @ScottKellum which I think is very easy to incorporate for Authors that use the Sass port of Typeplate. If they already have Sass most likely they have Ruby and Gems so to install another Gem for Scott's modular scale project is no big deal IMO over having it hard coded in the project.
Personally I want to avoid a dependency on any more gems. The more vanilla Sass we have, the better.
As much as I like the way the gem works, I actually use Tim Brown's modularscale.com instead, I like to get it in a browser window and copy-paste. That's how we got the default values to plug into our own function, we can link to it as an easy option too.
It should be easy to rip ours out and use Scott's gem, either way. CHOICE!
@zakkain Until Sass natively supports exponents my modular-scale gem will only be installable as a gem or though Bower on Compass. I have some Ruby in there to efficiently add that functionality and support non integers on the scale.
IMO dependencies (gems or Bower) are really easy to manage and way easier to update than copy/paste. Most projects I try to avoid Ruby so copy/paste works but yeah, happy to see Bourbon is supporting double standards now.
@scottkellum
IMO dependencies (gems or Bower) are really easy to manage and way easier to update than copy/paste.
So true which is why I have your modular scale project linked in the new docs of our dev branch atm. No need to remake it when you do a great job as it is. If authors want it then they can install the gem. No dependencies. Just little packages to add on as I see it. :metal:
The dependency model does look a lot easier, but I'm still clinging to the old Notepad copy-paste ways a little bit ;) :older_man:
@zakkain You are the Devil!
@zakkain I guess I'll have to do the same with 2 scales ( http://modularscale.com/ ) until this feature gets integrated into http://typeplate.com/ - which ever method you go for +1 for double strand and rem output ;)
Cheers,
Hey,
I just helped push this through in http://bourbon.io/docs/#modular-scale : https://github.com/thoughtbot/bourbon/pull/175 https://github.com/thoughtbot/bourbon/commit/5bdaa07c0fcfa6f1e3507185fa805741eeb33952
I'd really like to see double strand functionality in http://typeplate.com/ too
Yours hopefully,